LGTM
When this lands, I can remove the hack I wrote the MS C++ ABI that caused
PR17514.
+ // We can't use an alias if the linkage is not valid for one.
+ if (!llvm::GlobalValue::isExternalLinkage(Linkage) &&
+ !llvm::GlobalValue::isLocalLinkage(Linkage) &&
+ !llvm::GlobalValue::isWeakLinkage(Linkage) &&
+ !llvm::GlobalValue::isLinkOnceLinkage(Linkage))
return true;
Maybe this list should be something like GlobalAlias::isValidLinkage(), if
it's documented in LangRef.
On Tue, Oct 8, 2013 at 6:47 AM, Rafael Espíndola <[email protected]
> wrote:
> The llvm patch has been committed. Is the clang patch OK too?
>
> A rebased version is attached.
>
> Cheers,
> Rafael
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
