================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:387
@@ +386,3 @@
+private:
+ class MatcherState : public RefCountedBaseVPTR {
+ public:
----------------
Manuel Klimek wrote:
> I'd probably call it MatcherStorage or something, as it's supposed to store
> the matcher?
>
> State always sounds like it would store something during a match...
Done.
================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:400
@@ +399,3 @@
+
+ template <typename T> class MatcherStateImpl : public MatcherState {
+ public:
----------------
Manuel Klimek wrote:
> I'd probably call that DynamicMatcherState...
Since the base class is called "Storage", I named this one TypedStorage.
http://llvm-reviews.chandlerc.com/D1661
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
