Hi Reid, On Oct 10, 2013, at 10:13 AM, Reid Kleckner <[email protected]> wrote:
> Do you intend to use the accessor elsewhere? For the one use of the accessor > in the static helper function, maybe it's better to pass CGM into it and then > delete the accessor? > Thanks for taking a look. The patch I sent out more recently to decouple the creation of CodeGenModule and CodeGenTypes removes CGM from CodeGenTypes and adds a TargetCodegenInfo* directly to CodeGenTypes, so this code becomes CGT.getTargetCodeGenInfo()…. I don’t think anybody has had a chance to take a close look at that patch yet, so I’ll do as you suggest for now and just pass a CGM& in directly from the two call sites to this function. Mark > Either way the privatizing looks good. > > > On Thu, Oct 3, 2013 at 2:26 PM, Mark Lacey <[email protected]> wrote: > > Add an accessor for the CodeGenModule reference stored in CodeGenTypes. > > No functionality differences. > --- > lib/CodeGen/CGCall.cpp | 2 +- > lib/CodeGen/CodeGenTypes.h | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
