Should be able to write a test that checks the IR to make sure we don't have wrong paths. The backend just gets the info from the metadata.
-eric On Thu, Oct 17, 2013 at 11:48 AM, Hans Wennborg <[email protected]> wrote: > On Thu, Oct 17, 2013 at 8:09 AM, Yaron Keren <[email protected]> wrote: >> Hi, >> >> Filename appending in CGDebugInfo.cpp was implemented as simple string >> concatenation, resulting in duplicate file debug information on Windows due >> to wrong path separator. >> >> The patch uses llvm::sys::path::append to properly append the filename on >> all OS. >> >> Is there a way to use path::append without the SmallString temporary? >> >> Yaron > > The patch looks reasonable to me, but I wish there were a test we > could update for this. > > Maybe the debug info folks know if there is a test that picks up the > -main-file-name? > > - Hans _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
