Bah. The formatting didn't go in the email as I'd expected. Before:
1. CharSourceRange LineRange = CharSourceRange::getTokenRange( 2. Line.Tokens.front().Tok.getLo(), Line.Tokens.back().Tok.getLoc()); 3. After: 1. CharSourceRange LineRange = 2. CharSourceRange::getTokenRange(Line.Tokens.front().Tok.getLo(), 3. Line.Tokens.back().Tok.getLoc()); Whee. -eric On Tue, Oct 22, 2013 at 5:37 PM, Eric Christopher <[email protected]>wrote: > Hi Daniel, > > Thought I'd send it out and get some discussion if people care and > then I can update the tests and commit if we think it's a good idea. > > It'll change code like in (one of the) failing tests: > > Value of: format(messUp(Code), Style) > Actual: "CharSourceRange LineRange =\n > CharSourceRange::getTokenRange(Line.Tokens.front().Tok.getLo(),\n > Line.Tokens.back().Tok.getLoc());" > Expected: Code.str() > Which is: "CharSourceRange LineRange = > CharSourceRange::getTokenRange(\n Line.Tokens.front().Tok.getLo(), > Line.Tokens.back().Tok.getLoc());" > [ FAILED ] FormatTest.BreaksAfterAssignments (5 ms) > [----------] 1 test from FormatTest (5 ms total) > > this: > > <pre style='color:#000000;background:#ffffff;'><html><body > style='color:#000000; background:#ffffff; '><pre> > CharSourceRange LineRange <span style='color:#808030; '>=</span> > CharSourceRange<span style='color:#800080; > '>::</span>getTokenRange<span style='color:#808030; > '>(</span>Line<span style='color:#808030; '>.</span>Tokens<span > style='color:#808030; '>.</span>front<span style='color:#808030; > '>(</span><span style='color:#808030; '>)</span><span > style='color:#808030; '>.</span>Tok<span style='color:#808030; > '>.</span>getLo<span style='color:#808030; '>(</span><span > style='color:#808030; '>)</span><span style='color:#808030; '>,</span> > Line<span style='color:#808030; > '>.</span>Tokens<span style='color:#808030; '>.</span>back<span > style='color:#808030; '>(</span><span style='color:#808030; > '>)</span><span style='color:#808030; '>.</span>Tok<span > style='color:#808030; '>.</span>getLoc<span style='color:#808030; > '>(</span><span style='color:#808030; '>)</span><span > style='color:#808030; '>)</span><span style='color:#800080; '>;</span> > </pre> > > versus: > > <pre style='color:#000000;background:#ffffff;'><html><body > style='color:#000000; background:#ffffff; '><pre> > CharSourceRange LineRange <span style='color:#808030; '>=</span> > CharSourceRange<span style='color:#800080; > '>::</span>getTokenRange<span style='color:#808030; '>(</span> > Line<span style='color:#808030; '>.</span>Tokens<span > style='color:#808030; '>.</span>front<span style='color:#808030; > '>(</span><span style='color:#808030; '>)</span><span > style='color:#808030; '>.</span>Tok<span style='color:#808030; > '>.</span>getLo<span style='color:#808030; '>(</span><span > style='color:#808030; '>)</span><span style='color:#808030; '>,</span> > Line<span style='color:#808030; '>.</span>Tokens<span > style='color:#808030; '>.</span>back<span style='color:#808030; > '>(</span><span style='color:#808030; '>)</span><span > style='color:#808030; '>.</span>Tok<span style='color:#808030; > '>.</span>getLoc<span style='color:#808030; '>(</span><span > style='color:#808030; '>)</span><span style='color:#808030; > '>)</span><span style='color:#800080; '>;</span> > </pre> > > which while the former is more lines I think it is a much more legible > general formatting style. > > Thoughts? > > -eric >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
