Thanks! > Don't we need at least the definitions of AlignedCharArrayUnion and the > non-pointer types put into that:
The code does compile without it.. but I guess it's because AlignedCharArrayUnion is defined indirectly through one of the remaining #include. I will consider this aspect much better in the future. So I am fine if my patch is just "forgotten" for now. Best regards, Daniel Marjamäki .................................................................................................................. Daniel Marjamäki Senior Engineer Evidente ES East AB Warfvinges väg 34 SE-112 51 Stockholm Sweden Mobile: +46 (0)709 12 42 62 E-mail: Daniel.Marjamaki<mailto:[email protected]>@evidente.se<mailto:[email protected]> www.evidente.se ________________________________ Från: Manuel Klimek [[email protected]] Skickat: den 23 oktober 2013 16:23 Till: Daniel Marjamäki Cc: [email protected] Ämne: Re: [PATCH] cleanup redudant includes in ASTTypeTraits.h Don't we need at least the definitions of AlignedCharArrayUnion and the non-pointer types put into that: llvm::AlignedCharArrayUnion<KindsByPointer, TemplateArgument, NestedNameSpecifierLoc, QualType, TypeLoc> Storage; For the rest, I can see that we might want to make callers responsible for having the type defined if they instantiate the template. On Tue, Oct 22, 2013 at 5:44 PM, Daniel Marjamäki <[email protected]<mailto:[email protected]>> wrote: Hello! This is a small cleanup of some redundant #include's in ASTTypeTraits.h. No change in behaviour is intended. I just want to cleanup. The code compiles and all tests pass. However I believe there could be a danger with this change. There could be some "preprocessor magic". I assume that these headers were included because some types/variables/etc were needed. Best regards, Daniel Marjamäki .................................................................................................................. Daniel Marjamäki Senior Engineer Evidente ES East AB Warfvinges väg 34 SE-112 51 Stockholm Sweden Mobile: +46 (0)709 12 42 62<tel:%2B46%20%280%29709%2012%2042%2062> E-mail: Daniel.Marjamaki<mailto:[email protected]>@evidente.se<mailto:[email protected]> www.evidente.se<http://www.evidente.se> _______________________________________________ cfe-commits mailing list [email protected]<mailto:[email protected]> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
