Looks fine to me, just a couple nits.
================
Comment at: ../tools/clang/runtime/compiler-rt/Makefile:237
@@ -214,3 +236,3 @@
all-local:: $(RuntimeDirs:%=RuntimeLibrary.%)
-install-local:: $(RuntimeDirs:%=RuntimeLibraryInstall.%)
+install-local:: $(RuntimeDirs:%=RuntimeLibraryInstall.% RuntimeHeaderInstall)
clean-local:: CleanRuntimeLibraries
----------------
Shouldn't this be:
--
install-local:: $(RuntimeDirs:%=RuntimeLibraryInstall.%) RuntimeHeaderInstall
--
It doesn't break, but otherwise it is expanding to RuntimeLibraryInstall.foo
RuntimeHeaderInstall RuntimeLibraryInstall.bar RuntimeHeaderInstall
================
Comment at: ../tools/clang/runtime/compiler-rt/Makefile:231
@@ +230,3 @@
+ $(PROJ_resources_include)/sanitizer
+
+RuntimeHeaderInstall: $(PROJ_resources_include)/sanitizer
----------------
Might as well put these next to the PROJ_resources_lib rule earlier.
================
Comment at: ../tools/clang/runtime/compiler-rt/Makefile:141
@@ -138,3 +140,3 @@
# possible.
-BuildRuntimeLibraries:
+BuildRuntimeLibraries: $(ResourceIncludeDir)/sanitizer
$(Verb) $(MAKE) -C $(COMPILERRT_SRC_ROOT) \
----------------
I think it is more clear to make this a separate rule that all-local depends
on, similar to install. It would be consistent with the rest of the header to
have
all-local:: ... RuntimeHeader
RuntimeHeader: $(ResourceIncludeDir)/sanitizer
http://llvm-reviews.chandlerc.com/D1959
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
