On 27 October 2013 10:01, Logan Chien <[email protected]> wrote: > > Besides, I feel it will be even better to add the test cases for > arm-linux-gnueabi as well.
Good point. I will add one. > FYI. I have created a patch for this change: > https://github.com/loganchien/clang/compare/b0e00c2...630a9e3 > > > ================ > Comment at: test/Driver/linux-ld.c:260 > @@ +259,3 @@ > +// CHECK-X86-64-UBUNTU-13-10-ARM-HF: > "-L[[SYSROOT]]/usr/lib/gcc-cross/arm-linux-gnueabihf/4.8/../../../../arm-linux-gnueabihf/lib/../lib" > +// CHECK-X86-64-UBUNTU-13-10-ARM-HF: "-L[[SYSROOT]]/lib/../lib" > +// CHECK-X86-64-UBUNTU-13-10-ARM-HF: "-L[[SYSROOT]]/usr/lib/../lib" > ---------------- > It seems that SYSROOT/lib is not added to version control. Maybe you have to > put a placeholder such as .keep? > > e.g. > mkdir -p Inputs/x86-64_ubuntu_13.10/lib > touch Inputs/x86-64_ubuntu_13.10/lib/.keep > git add Inputs/x86-64_ubuntu_13.10/lib/.keep Fixed, thanks. > ================ > Comment at: test/Driver/linux-ld.c:262 > @@ +261,3 @@ > +// CHECK-X86-64-UBUNTU-13-10-ARM-HF: "-L[[SYSROOT]]/usr/lib/../lib" > +// CHECK-X86-64-UBUNTU-13-10-ARM-HF: > "-L[[SYSROOT]]/usr/lib/gcc-cross/arm-linux-gnueabihf/4.8/../../../../arm-linux-gnueabihf/lib" > +// CHECK-X86-64-UBUNTU-13-10-ARM-HF: > "{{.*}}/usr/lib/gcc-cross/arm-linux-gnueabihf/4.8/crtend.o" > ---------------- > It seems we can add two more checks after this line: > CHECK-X86-64-UBUNTU-13-10-ARM-HF: > "-L[[SYSROOT]]/usr/lib/gcc-cross/arm-linux-gnueabihf/4.8/../../.." > CHECK-X86-64-UBUNTU-13-10-ARM-HF: "-L[[SYSROOT]]/usr/lib" I added checks for only the lines gcc prints. I tested that with arm-linux-gnueabihf-gcc-4.8 ~/llvm/test.o -o t -Wl,-debug 2>&1 | grep bin/ld | sed 's/ /\n/g' | grep -- -L Ideally clang should not be printing these extra lines. Adding them to the test given the impression that they are required. Cheers, Rafael _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
