Hi Jiangning, Just one small refactor that needs to happen here. Mostly it looks fine to me.
Cheers Tim ================ Comment at: lib/Target/AArch64/AArch64InstrNEON.td:3953 @@ +3952,3 @@ + let ParserMatchClass = uimm3_asmoperand; + let PrintMethod = "printNeonUImm8Operand"; +} ---------------- OK, this function seriously needs renaming now. I don't know why I didn't notice before. http://llvm-reviews.chandlerc.com/D2073 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
