LGTM
On Tue, Oct 29, 2013 at 7:48 AM, Rafael Espíndola < [email protected]> wrote: > ping > > On 25 September 2013 17:44, Rafael Espíndola <[email protected]> > wrote: > > With this patch -Wwrite-strings is still implemented with the terrible > > hack of passing -fconst-strings to -cc1, but at least the driver uses > > the regular warning checking code path. > > > > Since we don't support a warning that is DefaultIgnore in one language > > but not in another, this patch > > creates a dummy C only warning in the same group as the existing one > > to get the desired effect. > > > > Chandler, is the include of clang/Sema/SemaDiagnostic.h OK in here or > > some extra refactoring is needed? > > > > Cheers, > > Rafael >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
