On 5 November 2013 13:23, Reid Kleckner <r...@google.com> wrote:
> Looks good, I'm fairly confident this will DTRT.
>
> As a followup someone should remove the hack at the top of
> GetAddrOfCXXDestructor.
>
> + typedef llvm::StringMap<llvm::TrackingVH<llvm::Constant> >
> ReplacemensType;
> + ReplacemensType Replacements;
>
> typo
>
> Do we prefer Type or Ty for typedefs?
>
Ty, by a bit:
$ git grep typedef.*Type\; | wc
115 525 9233
$ git grep typedef.*Ty\; | wc
220 1166 21253
I will update before committing.
Cheers,
Rafael
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
