On Wed, Nov 6, 2013 at 7:39 AM, Alp Toker <[email protected]> wrote: > > On 06/11/2013 14:55, Anthony Scopatz wrote: > > Hello All, > > > > Could we please hear some response on this? Thanks! > > Hello Anthony, Geoffrey, > > Thanks for the contribution. > > You'll need to rebase this work against current SVN, add at least a > couple of standard lit tests and probably split it up into two or three > bite-size chunks for review. > > Once that's done, it can also help to CC in others who've recently > worked on the C API in order to get buy-in. >
Thanks Alp, Do you have any suggestions on who to CC or should we just look at the logs? Thanks! Be Well Anthony > > As for the Geoffrey's build problem, it's best to ask that as a separate > question, including details about the platform and configuration if > you're still struggling. > > Good luck with the patch :-) > > Alp. > > > > > > > Be Well > > Anthony > > > > > > On Sun, Nov 3, 2013 at 5:46 PM, Geoffrey Irving <[email protected] > > <mailto:[email protected]>> wrote: > > > > Here are four patches improving libclang in various ways for use in > > xdress (http://xdress.org). In order, they add > > > > 1. Python support for clang_formatDiagnostic. > > 2. Access to public / private / protected specifiers. > > 3. Template argument access (as new cursor types). > > 4. A clang_Cursor_getDefaultArgument function. > > > > They've all been tested inside xdress, but the patches themselves do > > not include tests. Since questions about this stuff to cfe-dev were > > ignored, I want to make sure these patches will be looked at before I > > do potentially unnecessary work. > > > > Caveat: llvm trunk does not build for me due to these errors: > > > > llvm-build: error: invalid native target: 'x86_64' (not in > > project) > > > > Therefore, these patches were written, built, and tested again > > release_33 plus several cherry-picked libclang commits. It's > possible > > they don't compile against the trunk. > > > > Any ideas what would have caused this build breakage since > release_33? > > > > Thanks, > > Geoffrey > > > > > > > > > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > -- > http://www.nuanti.com > the browser experts > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
