Thanks for the feedback. I have attached the improved patch.
Thanks,
Johan
On 8-11-2013 22:25, Sean Silva wrote:
Your patch doesn't do what you think. In Python 2, it is still
invoking a print statement with the expression `(error)` which happens
to evaluate to just `error`. You need a `from __future__ import
print_function`, which will make it be a function call in both Python
2 and 3.
-- Sean Silva
On Fri, Nov 8, 2013 at 3:57 PM, Johan Engelen
<[email protected] <mailto:[email protected]>> wrote:
Hi all,
Sublime Text 3 uses Python 3.3 for its plugins (instead of 2.6
that Sublime Text 2 uses). The attached patch fixes
clang-format-sublime.py to work in Sublime Text 3.
I am not a Python expert, but it seems for this plugin, the only
relevant change is that "print" became a function, so parens are
needed.
I tested the change and the patched plugin works in both Sublime
Text 2 and 3.
Thanks for the review, (and commit ;)
Johan
_______________________________________________
cfe-commits mailing list
[email protected] <mailto:[email protected]>
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Index: tools/clang-format/clang-format-sublime.py
===================================================================
--- tools/clang-format/clang-format-sublime.py (revision 193933)
+++ tools/clang-format/clang-format-sublime.py (working copy)
@@ -12,6 +12,7 @@
# It operates on the current, potentially unsaved buffer and does not create
# or save any files. To revert a formatting, just undo.
+from __future__ import print_function
import sublime
import sublime_plugin
import subprocess
@@ -45,7 +46,7 @@
stderr=subprocess.PIPE, stdin=subprocess.PIPE)
output, error = p.communicate(buf.encode(encoding))
if error:
- print error
+ print(error)
self.view.replace(
edit, sublime.Region(0, self.view.size()),
output.decode(encoding))
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
