LGTM :) IMO RAUW is better because you actually put something in the module with the appropriate name that you can refer back to, and later it is removed transparently.
The current approach used to have a bug where we try to emit the complete dtor, which emits the base dtor, and then we try to emit the base dtor, which is already emitted. =/ On Tue, Nov 12, 2013 at 8:47 AM, Rafael Espíndola < [email protected]> wrote: > Now that the relevant tests use -mconstructor-aliases and the missing > features have been implemented, we can just drop this. > > This technique is quiet interesting and a bit more elegant than using > rauw, but it would require a fairly invasive change to how we emit > thunks to make it general, so it is probably better to just remove it > for now. > > Cheers, > Rafael >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
