Hi Kevin,

  Just spotted one small thing. It looks like there's a Neon_AllOne you could 
create along the lines of the Neon_AllZero. Everything else looks fine, so as 
far as I'm concerned you can make that change and commit immediately. I'll take 
a look at the svn log when it happens.

  Cheers.

  Tim.


================
Comment at: lib/Target/AArch64/AArch64InstrNEON.td:6647
@@ +6646,3 @@
+            (v8i16 VPR128:$Rn),
+            (v8i16 (bitconvert (v16i8 (Neon_movi (i32 255), (i32 14))))))),
+          (NOT16b VPR128:$Rn)>;
----------------
And is this AllOnes?


http://llvm-reviews.chandlerc.com/D2118
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to