It seems that the FIXME is already fixed:
NamedFileEnt = SeenFileEntries.GetOrCreateValue(Filename);
UFE.Name is const char* = InterndFileName = NamedFileEnt.getKeyData();
so eventually UFE.Name does point to the key of SeenFileEntries.
In the remaining comment we're adding a file, not a directory.
Yaron
Index: lib/Basic/FileManager.cpp
===================================================================
--- lib/Basic/FileManager.cpp (revision 194436)
+++ lib/Basic/FileManager.cpp (working copy)
@@ -339,9 +339,7 @@
return &UFE;
}
- // Otherwise, we don't have this directory yet, add it.
- // FIXME: Change the name to be a char* that points back to the
- // 'SeenFileEntries' key.
+ // Otherwise, we don't have this file yet, add it.
UFE.Name = InterndFileName;
UFE.Size = Data.Size;
UFE.ModTime = Data.ModTime;
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
