Great. Thanks, Hao. > Hi Chad, > > Thanks for the review. > I've changed to use CHECK-LABEL and committed in > http://llvm.org/viewvc/llvm-project?view=revision&revision=194954 > > Thanks, > -Hao > > -----Original Message----- > From: Chad Rosier [mailto:[email protected]] > Sent: Friday, November 15, 2013 2:17 AM > To: Hao Liu > Cc: [email protected] > Subject: Re: [PATCH][AArch64]Implement vreinterpret ACLE functions in > Clang > > Hao, > My only suggestion would be to use the CHECK-LABEL directive for each of > the > function names. Otherwise, LGTM. > > Chad > >> Hi, >> >> >> >> The attached patch implements the vreinterpret functions in Clang. As >> such functions are implemented by typecast, there is no instruction >> generated in the backend. So there is no patch for LLVM. >> >> >> >> This patch is very simple, it only add new types and test cases. >> >> Review. Please. >> >> >> >> Thanks, >> >> -Hao >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted > by > The Linux Foundation > > > > >
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
