Hi John, On Mon, Nov 18, 2013 at 6:45 PM, John Thompson <[email protected]> wrote: > > Regarding adding tests to clang/test that depend on pp-trace, I see your > point that it would make sense to have tests for something in clang in the > clang tree. I suppose new tests for new stuff in PPCallbacks could just be > added to the pp-trace tests.
As long as clang-tools-extra is an optional component, it makes no sense to me to have tests for PPCallbacks out there. The lexer's interaction with PPCallbacks is critical functionality for many tools, and it would be nice if that was tested irrespective of whether there's a pp-trace tool or not. For what it's worth, - Kim _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
