Hi Marshal, I checked and the #if !defined(_WIN32)...#endif change G M suggested was indeed missing from the code. At the time I did not have not have commit access. Now I do and committed the change r195045.
Yaron 2013/11/18 Marshall Clow <[email protected]> > On Oct 9, 2013, at 8:41 PM, G M <[email protected]> wrote: > > Hi Marshall > > The random patch doesn't seem to have the fix I suggested in my code > review here: > > http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090561.html > > Yaron mentioned he'd added it here: > > http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090566.html > > I don't know if you applied an old revision of his patch or yaron forgot > to add my suggestions after all but the attached patch makes it work for me > with MSVC. > > > I'm really sorry that I missed this. > Is this misapplication still in the libc++ sources? > > -- Marshall > > Marshall Clow Idio Software > <mailto:[email protected]<[email protected]> > > > > A.D. 1517: Martin Luther nails his 95 Theses to the church door and is > promptly moderated down to (-1, Flamebait). > -- Yu Suzuki > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
