On Thu, Nov 21, 2013 at 11:00 AM, Ted Kremenek <[email protected]> wrote: > Thanks for the feedback! > >> On Nov 21, 2013, at 5:27 AM, Aaron Ballman <[email protected]> wrote: >> >> You should also add a test case for the number and type of args passed in. >> > > We are deliberately not checking for the type of the arguments. The > protocol does not need to exist in the translation unit for this attribute > to be applied.
Small misunderstanding -- I meant you should add test cases to ensure proper diagnostics for things like an expr passed (instead of an ident), or no args/two args passed instead of one. ~Aaron _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
