On 23/11/2013 10:22, Jonathan Schleifer wrote:
The following patch changes the behavior of __attribute__((format(__NSString__,
…))) to also allow OFStrings as used in ObjFW. I thought about adding
__OFString__ instead, but thought this would be unnecessary overhead. If people
disagree, I'm more than happy to add __OFString__ instead.
Could you guys kindly review this patch and commit it if you deem it
acceptable? If so, it would also nice if it could be committed to 3.4 as well.
PS: Please CC me, I'm not on the list!
Hi Jonathan,
I couldn't find many projects outside of your website using the ObjFW
library. If it's a personal research project, that's great but it'd be
great to state it up front to help reviewers, especially since you're
proposing to merge it to the stable branch.
Given that you're not subscribing to the mailing list, the burden would
be on the rest of the community to maintain the feature once committed.
The GPL licensing for the library might make it harder to set up
automated tests for some people. None of this is unprecedented but
generally, the less mainstream the platform, the more there's a need to
make the case for it.
On a technical level, I suspect it'd be better to generalize the
problem, perhaps creating an attribute that you can apply to mark up
your OFString, OFConstantString and OFMutableString so anyone else
developing a runtime can also benefit from the format checker with their
own classes. This is more likely to be accepted by the project than
hard-coding class names into clang.
Alp.
--
Jonathan
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
--
http://www.nuanti.com
the browser experts
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
