On 26/11/2013 07:18, Dmitri Gribenko wrote:
On Mon, Nov 25, 2013 at 11:11 PM, Alp Toker <[email protected]> wrote:
In light of this, and considering also that we don't usually make an effort
to produce FixIts for warning-level diagnostics in Sema, the original patch
to the parser by Ondřej looks fine to me. Dmitri, is that OK with you?
Yes, this is fine for me. Of course, the original patch still needs
to be updated to silence the warning in case of (void) casts -- is
this what GCC does?
GCC doesn't warn on (void) casts.
The patch should be fixed to handle these cases too:
(void)x; // no warning
(long)x; // warning
The necessary checks can be done in Parse, but might be slightly easier
/ future-proof handle them in Sema.
Alp.
Dmitri
--
http://www.nuanti.com
the browser experts
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
