Thanks, LGTM On 28 Nov 2013 06:58, "Lubos Lunak" <[email protected]> wrote:
> On Thursday 28 of November 2013, Richard Smith wrote: > > Some tiny things: > > > > + // Ignore also all pragma in all namespaces created > > + // in Preprocessor::RegisterBuiltinPragmas(). > > > > The English in this (copy-pasted) comment is a bit awkward; can you fix > it > > to something like "Also ignore all pragmas in [...]" > > > > Please also add to your testcase an instance of a #pragma we don't > normally > > understand (#pragma this_pragma_does_not_exist or similar). > > Updated. > > > Otherwise, LGTM, thanks! > > > > On Wed, Nov 27, 2013 at 3:57 PM, Lubos Lunak <[email protected]> wrote: > > > Hello, > > > > > > the attached patch should fix PR9537. It is apparently necessary to > > > install > > > empty pragma handlers for all pragma namespaces that exist. > > > > > > -- > > > Lubos Lunak > > -- > Lubos Lunak >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
