On Mon, Dec 2, 2013 at 2:27 PM, Richard Smith <[email protected]> wrote:
> I guess the intent is to eventually switch over to generating
> include/clang/Basic/LangOptions.def with tablegen, with a shared .td file
> being used for both that and the attributes?
At some point, that would be nice. For right now, I took the cheap way
out and have explicitly declared the language options being used for
attributes.
> Please name your generated functions with a leading lowercase letter
> ("defaultDiagnoseLangOpts", "checkCPlusPlusLangOpts"); other than that,
> LGTM. Thank you!
Done, thanks! Committed in r196138. I'll do a follow-up commit for
the appertainsTo names.
~Aaron
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
