================
Comment at: tools/clang-format-vs/CMakeLists.txt:6
@@ +5,3 @@
+ "${LLVM_TOOLS_BINARY_DIR}/clang-format.exe"
+ "${CMAKE_CURRENT_SOURCE_DIR}/ClangFormat/clang-format.exe"
+ DEPENDS clang-format)
----------------
Manuel Klimek wrote:
> One more thought - the source directory might not be writable, usually it's a
> best practice to use the output directory for this and a build variable to
> inject the path (don't know how exactly that works with MSVC, so I think this
> is fine for now).
I'll leave this as is for now until we can figure out a better way to do it.
================
Comment at: tools/clang-format-vs/CMakeLists.txt:10
@@ +9,3 @@
+ add_custom_target(clang_format_vsix ALL
+ devenv "${CMAKE_CURRENT_SOURCE_DIR}/ClangFormat.sln" /Build Release
+ DEPENDS clang_format_exe_for_vsix
----------------
Manuel Klimek wrote:
> Will that go to the right devenv regardless of the msvc version cmake uses?
> Otherwise I'd surround this by if (MSVC12)...
I guess it just picks whatever "devenv.exe" is on the PATH. My thinking is that
if that devenv can build it (vs 2012 or 2013) that's cool, and otherwise we'll
get an error message.
http://llvm-reviews.chandlerc.com/D2310
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
