Hello Renato, The krait cpu attribute is not yet supported by GNU assembler (work is going on though). The check prevents it from being printed.
I added the test you suggested. See updated patches attached. Thanks, Ana. -----Original Message----- From: Renato Golin [mailto:[email protected]] Sent: Wednesday, December 04, 2013 12:18 AM To: Ana Pazos Cc: llvm-commits; Clang Commits Subject: Re: [PATCH][ARM] Added support for krait cpu On 4 December 2013 00:00, Ana Pazos <[email protected]> wrote: > These patches add support for krait cpu in Clang and LLVM. Hi Ana, A few comments: - if (CPUString != "generic") + if (CPUString != "generic" && CPUString != "krait") ATS.emitTextAttribute(ARMBuildAttrs::CPU_name, CPUString); I wonder why no other named CPU had to do this. I'm not particularly comfortable with that. About the Clang patch, would be good if you could include other tests to match cpu->arch. (test/Driver/arm-cortex-cpus.c and friends). cheers, --renato
0002-clang-Added-support-for-mcpu-krait.patch
Description: Binary data
0002-llvm-Added-support-for-mcpu-krait.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
