Sure, seems reasonable. It's also consistent with the -Wconstant-conversion warning which warns about implicit conversions that truncate (char a = 500; char b = (char)500; const char c = (char)500; only warns about 'a').
Perhaps an additional test case or two to demonstrate that the suppression works in similar contexts to the warning, even in the qualified match case. Maybe comments describing this in the test and/or source? Up to you there. http://llvm-reviews.chandlerc.com/D2341 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
