Here's a quick response to one of the comments. I'll work on others tomorrow.


================
Comment at: unittests/Format/FormatTest.cpp:2085
@@ -2084,2 +2084,3 @@
 TEST_F(FormatTest, RespectWhitespaceInMacroDefinitions) {
-  verifyFormat("#define A (1)");
+  EXPECT_EQ("#define A (x)", format("#define A (x)"));
+  EXPECT_EQ("#define A(x)", format("#define A(x)"));
----------------
Daniel Jasper wrote:
> I think having this test once is sufficient (it is also below).
If you mean the one at lines 6703-6704, it's not redundant, it tests 
SpaceBeforeParens: Always.


http://llvm-reviews.chandlerc.com/D2326

BRANCH
  svn

ARCANIST PROJECT
  clang
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to