On Dec 10, 2013, at 5:41 , Anders Rönnholm <[email protected]> wrote:
> Thanks for the comments. New iteration with the comments addressed.
>
> + + static PathDiagnosticLocation createConditionalColonLoc(
> + + const
> ConditionalOperator *CO,
> + + const SourceManager &SM);
>
> + + I think the new style is to either break after the return type or to
> double-indent wrapped arguments, rather than right-aligning + them.
> (Right-aligning is harder to maintain.)
>
> I'd like to keep this as it is since there are other create functions next to
> it that uses this style, this also applies to the ccp file. We could make a
> separate patch later and change them all to the new style. I believe the
> coding standard also states that we should use the same style already used in
> the source.
Fair enough. Committed in r196937!
I also did some minor cleanups in r196938. Can you check that these look
correct?
Jordan
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
