Hi Reid,
I am not sure what you mean. I am not too familiar with the windows tool chain, but the error here looks reasonable. I see that there is actually a test that explicitly checks for that error: test/Driver/no-integrated-as-win.c You can get the error by compiling for windows with '-target win32 -no-integrated-as'. My test used the -no-integrated-as flag and was failing because the default target on your build was win32, so I explicitly set the target in the test. Is there something more to fix here? From: Reid Kleckner [mailto:[email protected]] Sent: Monday, December 09, 2013 7:39 PM To: David Peixotto Cc: [email protected] cfe Subject: Re: r196854 - Fix via-file-asm test failure on windows There's still an assert here I'd like to get fixed. If you remove the target we still crash. On Mon, Dec 9, 2013 at 4:54 PM, David Peixotto <[email protected]> wrote: Author: dpeixott Date: Mon Dec 9 18:54:30 2013 New Revision: 196854 URL: http://llvm.org/viewvc/llvm-project?rev=196854 <http://llvm.org/viewvc/llvm-project?rev=196854&view=rev> &view=rev Log: Fix via-file-asm test failure on windows The windows target does not support using an external assembler so the test case was failing with this error: error: there is no external assembler that can be used on this platform The test was updated to always explicitly pass a target that has both an interal and external assembler. Modified: cfe/trunk/test/Driver/via-file-asm.c Modified: cfe/trunk/test/Driver/via-file-asm.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/via-file-asm.c?rev =196854 <http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/via-file-asm.c?re v=196854&r1=196853&r2=196854&view=diff> &r1=196853&r2=196854&view=diff ============================================================================ == --- cfe/trunk/test/Driver/via-file-asm.c (original) +++ cfe/trunk/test/Driver/via-file-asm.c Mon Dec 9 18:54:30 2013 @@ -1,14 +1,10 @@ // Should save and read back the assembly from a file -// RUN: %clang -integrated-as -via-file-asm %s -### 2>&1 | FileCheck %s +// RUN: %clang -target arm-none-linux-gnueabi -integrated-as -via-file-asm %s -### 2>&1 | FileCheck %s // CHECK: "-cc1" // CHECK: "-o" "[[TMP:[^"]*]]" // CHECK: -cc1as // CHECK: [[TMP]] // Should not force using the integrated assembler -// RUN: %clang -no-integrated-as -via-file-asm %s -### 2>&1 | FileCheck --check-prefix=NO_IAS %s +// RUN: %clang -target arm-none-linux-gnueabi -no-integrated-as -via-file-asm %s -### 2>&1 | FileCheck --check-prefix=NO_IAS %s // NO_IAS-NOT: "-cc1as" - -// Test arm target specifically for the same behavior -// RUN: %clang -target arm -integrated-as -via-file-asm %s -### 2>&1 | FileCheck %s -// RUN: %clang -target arm -no-integrated-as -via-file-asm %s -### 2>&1 | FileCheck --check-prefix=NO_IAS %s _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
