Hans,
Instead of reverting, I think it's OK* to back out just the part of the
changes that made -re optional.
With that change it's fine by me as long as we continue to observe the
situation on ToT. It was unfortunately one of those features that may
make writing a test easier but has a much higher ongoing maintenance
cost after the initial commit is done.
* I'm still also somewhat opposed to the {{{{}}}} syntax and Richard's
assessment -- after all, preprocessor #if conditionals and C if
statements also do the same thing but nobody has yet proposed that they
should look the same.
Making the -verify syntax similar to FileCheck is /very/ confusing to
newcomers who need to be aware that they are very distinct testing tools
-- sometimes different is good and I'd like to encourage more people get
involved writing lit tests and this raises the barrier of understanding.
Alp.
On 12/12/2013 21:52, Hans Wennborg wrote:
On Thu, Dec 12, 2013 at 11:38 AM, Alp Toker <[email protected]> wrote:
Reading through SVN history shows that over years any syntax that isn't
shored up tends to break.
Yes, I agree we might have relaxed these tests a bit too much.
Requiring -re on directives with regexes makes them easier to grep
for, but I don't know how important that is.
Looking at the changes today, I'm starting to think anything to make regex
expressions stand out is a good idea.
I think they do stand out a bit already with the extra {{'s, but sure,
explicitly putting -re on the directives makes them stand out even
more.
Anyway, I'm curious to hear what Richard thinks here.
- Hans
--
http://www.nuanti.com
the browser experts
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
