Re: [PATCH] Fix crash in CFGReachabilityAnalysis triggered by IdempotentOperationChecker.

[Alexander Kornienko]

  Changed the check to an assertion.

Hi krememek,

http://llvm-reviews.chandlerc.com/D2427

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D2427?vs=6148&id=6162#toc

Files:
  lib/Analysis/CFGReachabilityAnalysis.cpp

Index: lib/Analysis/CFGReachabilityAnalysis.cpp
===================================================================
--- lib/Analysis/CFGReachabilityAnalysis.cpp
+++ lib/Analysis/CFGReachabilityAnalysis.cpp
@@ -23,7 +23,9 @@
   : analyzed(cfg.getNumBlockIDs(), false) {}
 
 bool CFGReverseBlockReachabilityAnalysis::isReachable(const CFGBlock *Src,
-                                          const CFGBlock *Dst) {
+                                                      const CFGBlock *Dst) {
+  // Blocks must be from the same CFG.
+  assert(Src->getParent() == Dst->getParent());
 
   const unsigned DstBlockID = Dst->getBlockID();

Index: lib/Analysis/CFGReachabilityAnalysis.cpp
===================================================================
--- lib/Analysis/CFGReachabilityAnalysis.cpp
+++ lib/Analysis/CFGReachabilityAnalysis.cpp
@@ -23,7 +23,9 @@
   : analyzed(cfg.getNumBlockIDs(), false) {}
 
 bool CFGReverseBlockReachabilityAnalysis::isReachable(const CFGBlock *Src,
-                                          const CFGBlock *Dst) {
+                                                      const CFGBlock *Dst) {
+  // Blocks must be from the same CFG.
+  assert(Src->getParent() == Dst->getParent());
 
   const unsigned DstBlockID = Dst->getBlockID();
   

_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits