On Dec 26, 2013, at 9:08 PM, Nico Weber <[email protected]> wrote: > (As background: we have a fairly aggressive license checking script in > chromium land that complained about this. We've blacklisted libc++ for that > script for now, but since adding these headers seems like the right thing to > do anyways I sent out this patch.) > > > On Thu, Dec 26, 2013 at 9:06 PM, Daniel Berlin <[email protected]> wrote: > I'm completely indifferent about this. Legally, the worst that could happen > is someone could take the tests and use them and claim they didn't know they > were copyrighted or licensed. They'd probably lose anyway, but they could at > least claim that if their is no notice. > The question, which i offer no real opinion on, is "do we care if that > happens". > > For tests, I usually have a really hard time working up any desire to care > enough to tell people to be checking headers.
I don’t have a strong opinion about this (the lack of license info in tests); but I’ve reviewed the patch, and I see nothing here that would cause any problems. As for the ones in include and src, I think you should get an OK from the person who committed those files (which would be theraven — cc'ing). — Marshall > > On Thu, Dec 26, 2013 at 8:51 PM, Chandler Carruth <[email protected]> > wrote: > Adding Danny as he may be able to clarify... > > > On Thu, Dec 26, 2013 at 11:44 PM, Alexander Potapenko <[email protected]> > wrote: > On a related subject, what's the policy regarding the LIT tests? None of them > has the license headers, but they are source code, too, and are presumably > distributed under the same licenses. > > On Dec 26, 2013 9:49 PM, "Nico Weber" <[email protected]> wrote: > Hi, > > we noticed that a handful of files in libc++ are missing license headers > (mostly test files, and some files added for the solaris port). The attached > patch adds them. Ok? > > Fixes PR18291. > > Nico > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
