The patch is OK by me.
It is all MachO specific, so I would suggest getting someone at Apple to take
another look. Another thing you might want to do is to split the patch a bit to
make it easier to read. Some possible sub patches.
* Rename DarwinTool to MachOTool.
* Update the method names to start with a lowercase letter.
*
================
Comment at: lib/Driver/ToolChains.h:214
@@ +213,3 @@
+ /// Add the linker arguments to link the ARC runtime library.
+ virtual void addLinkARCArgs(const llvm::opt::ArgList &Args,
+ llvm::opt::ArgStringList &CmdArgs) const {}
----------------
nit: Usually there is no advantage in having inline virtual methods (other than
the destructor) in non final classes.
http://llvm-reviews.chandlerc.com/D2416
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
