Please add a test showing that a declaration also gets placed in the correct section. LGTM with that.
On 6 January 2014 13:25, Richard Osborne <[email protected]> wrote: > Looks good to me from an XCore ABI point of view. I'm not familiar enough > with clang to know if this is the right place to put this logic. > > > On 09/12/13 17:43, Robert Lytton wrote: > > Hi, > > Here is a patch for the XCore CodeGen handling of constants. > > XCore target: add section information. > Xcore target ABI requires const data that is externally visible > to be handled differently if it has C-language linkage rather than > C++ language linkage. > > Follow up to: [cfe-dev] static const structures declared as "external global > %struct.S" instead of "external constant %struct.S" > > Thank you > > Robert > > > > -- > Richard Osborne | XMOS > http://www.xmos.com > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
