On Sun, Jan 5, 2014 at 5:34 PM, Michael Bao <[email protected]> wrote: > On Sat, Jan 4, 2014 at 1:39 PM, Aaron Ballman <[email protected]> wrote: >> >> That makes sense as to why you'd move it, but I'm still concerned >> about this changing the semantics. For instance, this can now fire for >> ObjCMethodDecl objects, where it used to not be possible. This could >> be a bug fix, but it would also require further testing (and >> confirmation from some of the ObjC experts as to whether this is >> desirable). > > Hm, wouldn't the wrap around the diagnostic call with > > if (const FunctionDecl *FD = getCurFunctionDecl()) { > } > > prevent it from firing for ObjCMethodDecl objects?
Ah, yes, that would, sorry for the needless worry. Having had the chance to look at it in context with greater detail, I retract my concerns about the position of the code. ~Aaron _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
