On Thu, Jan 9, 2014 at 6:02 AM, Alp Toker <[email protected]> wrote: > Hi Kostya, > > This doesn't look correct and fires warnings my my strict checks build. >
I'm pretty sure the change works correctly, and it was definitely what Kostya and I intended. > > Double-underscore prefixed identifiers are strictly reserved for the > implementation. > Yes, and LeakSanitizer is something provided by the implementation? (the toolchain's runtime libraries specifically) I don't see any problem with double underscore here, any more than with __builtin_... functions or any of the other sanitizer interfaces. Can you clarify exactly what the error is and why? It's possible we could provide a macro of some kind in the sanitizer headers to bundle this functionality up if we need some special marking of this for checkers, but without more information its hard to hell what the actual problem is.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
