Thanks! Committed in r198896.

On Thu, Jan 9, 2014 at 5:37 PM, Richard Smith <[email protected]> wrote:
> LGTM, thanks!
>
>
> +  default:
> +    // Type attributes are handled elsewhere; silently move on.
> +    assert(Attr.isTypeAttr() && "Non-type attribute not handled");
> +    break;
>
> Eventually it'd be nice to be able to TableGen a list of attributes we don't
> expect to see here, so we can automatically generate case labels for them,
> and get a compile-time error if something is missing from this switch
> statement.
>

I agree, that's a good idea.

~Aaron
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to