LGTM with suggestions
We should probably announce on cfe-dev that -cxx-abi is gone and all you need
now is the triple. Even though it was a -cc1 flag, lots of people are using it
with the gcc compatible driver.
================
Comment at: lib/Frontend/CompilerInvocation.cpp:1633
@@ -1635,2 +1632,3 @@
+ if (llvm::Triple(Opts.Triple).getOS() == llvm::Triple::Win32)
Opts.CXXABI = "microsoft";
}
----------------
Let's kill off this TargetOptions field and use Triple instead. There should
be very few instances of code looking at this. We should keep the TargetCXXABI
enum stuff.
================
Comment at: test/lit.cfg:251
@@ +250,3 @@
+print makeItaniumABITriple(config.target_triple)
+print makeMSABITriple(config.target_triple)
+
----------------
These debug prints should go away.
http://llvm-reviews.chandlerc.com/D2545
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
