On Jan 14, 2014, at 2:01 PM, Sean Silva <[email protected]> wrote:

> http://llvm.org/docs/CodingStandards.html#commenting
> 
> "When writing comments, write them as English prose, which means they should 
> use proper capitalization, punctuation, etc. “
In r199258.

- Fariborz

> 
> -- Sean Silva
> 
> 
> On Tue, Jan 14, 2014 at 4:33 PM, Fariborz Jahanian <[email protected]> 
> wrote:
> Author: fjahanian
> Date: Tue Jan 14 15:33:54 2014
> New Revision: 199257
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=199257&view=rev
> Log:
> ObjectiveC. add comment.
> 
> Modified:
>     cfe/trunk/lib/CodeGen/CGObjCMac.cpp
> 
> Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp
> URL: 
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCMac.cpp?rev=199257&r1=199256&r2=199257&view=diff
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/CGObjCMac.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGObjCMac.cpp Tue Jan 14 15:33:54 2014
> @@ -4293,14 +4293,14 @@ llvm::Value *CGObjCMac::EmitIvarOffset(C
>  ///   unsigned flags;
>  /// };
>  enum ImageInfoFlags {
> -  eImageInfo_FixAndContinue      = (1 << 0),
> +  eImageInfo_FixAndContinue      = (1 << 0), // no longer set by clang
>    eImageInfo_GarbageCollected    = (1 << 1),
>    eImageInfo_GCOnly              = (1 << 2),
> -  eImageInfo_OptimizedByDyld     = (1 << 3), // FIXME: When is this set.
> +  eImageInfo_OptimizedByDyld     = (1 << 3), // set by the dyld shared cache
> 
>    // A flag indicating that the module has no instances of a @synthesize of a
>    // superclass variable. <rdar://problem/6803242>
> -  eImageInfo_CorrectedSynthesize = (1 << 4),
> +  eImageInfo_CorrectedSynthesize = (1 << 4), // no longer set by clang
>    eImageInfo_ImageIsSimulated    = (1 << 5)
>  };
> 
> 
> 
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to