Hi Weiming,
I think __thumb2_ should be set regardless of whether we're generating ARM or Thumb code - and I think this is what your patch does. Isn't the check of the ArchName string redundant with the check for CPUArchVer == 8? If I'm right then the tests need a corresponding adjustment. I'd also slightly prefer that you check for CPUArchVer >= 7, rather than checking for == 7 and ==8, but I don't feel all that strongly about it. Looks like we should consider moving the tests in Preprocessor/arm-target-features.c into Preprocessor/init.c, but that's not your problem :) Regards, Bernie From: [email protected] [mailto:[email protected]] On Behalf Of Weiming Zhao Sent: 14 January 2014 01:03 To: [email protected] Subject: [PATCH] add predefined macros for thumbv8 Hi, Attached patch adds 2 predefined macros to thumbv8 target: __thumb2__ __ __THUMB_INTERWORK__ See http://llvm.org/bugs/show_bug.cgi?id=18465 Please help to review it. Thanks, Weiming Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
