> Why is this code now commented out?

It's looked "fishy" to me ;-) and it didn't break any tests when I
removed it, but I left it there in case I ever discover why it was
there.

> I think you have to check whether the function is static or not as well.

Good point.  Thanks!

> These can be hoisted into the enclosing if.

Will do.

> Quite a few style guideline mishaps in here (extra newlines, curly
> braces when they should be elided, else clauses on their own line,
> etc). It might make sense to run clang-format over the file at some
> point.

Maybe, but we're not supposed to change SVN blame...

  -DeLesley

-- 
DeLesley Hutchins | Software Engineer | [email protected] | 505-206-0315
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to