Sorry, this is the first time I have tried arcanist (I thought `arc diff` would give me the diff :) ), and it seems like patch is posted before removing macros from the test case, and responding to your last feedback.
Nevertheless, yes, the condition can be simplified, as long as `DeprecatedStringLiteralToCharPtr` is initialized. It turned out it wasn't always initialized. CHECK_BEST seems like irrelevant, and will be removed. If the rest seems ready, I will remove them before commit, instead of posting another patch. http://llvm-reviews.chandlerc.com/D1965 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
