================ Comment at: lib/Driver/Tools.cpp:7110 @@ +7109,3 @@ + // Thus we use TY_INVALID, a bogus ObjCRuntime and KernelOrKext is false. + addExceptionArgs(Args, types::TY_INVALID, getToolChain().getTriple(), + false, ObjCRuntime(), CmdArgs); ---------------- This looks a bit hackish.
It also doesn't match what you had in the previous patch. For example, before it would consider fcxx_exceptions, but the current patch doesn't. This is probably an improvement, but it is something to be aware of. What would probably be the cleanest is to refactor the Kext and file type independent part of addExceptionArgs. Basically write a function with what is currently lines1537 to 1557 that returns ExceptionsEnabled and ShouldUseExceptionTables. That function can then be called from addExceptionArgs and XCore::Link::ConstructJob. http://llvm-reviews.chandlerc.com/D2570 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
