Committed as r200971.
On 6 February 2014 22:13, Renato Golin <[email protected]> wrote: > On 6 February 2014 16:31, Oliver Stannard <[email protected]> wrote: >> >> Having said that, it took long enough to convince myself that version two >> of the patch is correct that I have re-written it to make it clearer, new >> version of the patch is attached. > > > Hi Oliver, > > It looks a lot better now, thanks! It was a bit of a mess and I got > completely confused, which would also have confused future developers, too. > :) > > LGTM, apart from an unnecessary white-space change in an unrelated file: > > - "fits_in_regs"); > + "fits_in_regs"); > > cheers! > --renato > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
