On Tue, Feb 11, 2014 at 12:37 PM, Jordan Rose <[email protected]> wrote: > > On Feb 11, 2014, at 9:36 , Aaron Ballman <[email protected]> wrote: > > + if (D->getFunctionType()) { > + handleNonNullAttr(S, D, Attr); > + } else { > + S.Diag(Attr.getLoc(), diag::warn_attribute_nonnull_parm_no_args) > + << D->getSourceRange(); > + } > > > Minor nit about the style -- shouldn't be using the curly braces here. > > > Uh...hm. I tried it without the curly braces, but it looked very strange > with the << dangling there. Should I add a dummy comment to justify it?
I'm not too keen on dummy comments. If you think it's ugly without the braces, I'm fine with leaving them. :-) ~Aaron _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
