================ Comment at: include/clang/Driver/CLCompatOptions.td:108 @@ -99,1 +107,3 @@ +def _SLASH_vmv : CLFlag<"vmv">, + HelpText<"Set the default most general representation to virtual inheritance">; def _SLASH_W0 : CLFlag<"W0">, HelpText<"Disable all warnings">, Alias<w>; ---------------- Please update test/Driver/cl-options.c to cover these if possible.
================ Comment at: lib/Driver/Tools.cpp:4028 @@ +4027,3 @@ + D.Diag(clang::diag::err_drv_argument_not_allowed_with) + << "-vmg" << "-vmb"; + ---------------- can we have a test for this? ================ Comment at: lib/Driver/Tools.cpp:4042 @@ +4041,3 @@ + << InheritanceModelArgs[1]->getAsString(Args); + + // Default to vmv if a representation wasn't explicitly specified. ---------------- Tests would be nice. Also, this is pretty hard to follow. Does it get too ugly if you just handle the three cases separately? I.e. "if we have vms, check that we don't have vmm or vmv", and so on? http://llvm-reviews.chandlerc.com/D2741 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
