This looks good to me. As I understand it, this patch defers the tracking of RequiredAlignment to the locations that it probably should be tracked and corrects the rounding algorithm. An important thing to note here is RoundUpToAlignment(std::max(RequiredAlignment, Alignment)) is a new use of RequiredAlignment and demands the changes made to the tracking. Specifically we need the RequiredAlignment w/o the effects of virtual bases and the record's alignment.
http://llvm-reviews.chandlerc.com/D2674 BRANCH ms_layout ARCANIST PROJECT clang _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
