On Tue, Feb 11, 2014 at 11:26 PM, Daniel Jasper <[email protected]> wrote:

> -      OwnedBuffers.push_back(memBuf);
>
>
> Not adding MemoryBuffers to OwnedBuffers creates a memory leak. Did you
> intentionally remove that?
>

This can't have been intentional. Introducing leaks isn't OK, I think its
fine to either add back the necessary code or in a worst case given that
this was just dead code cleanup, revert. Otherwise the leak-checking build
bots will stay red. =[
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to