On Feb 20, 2014, at 9:35 , Brad King <[email protected]> wrote:

> On 02/20/2014 12:06 PM, Jordan Rose wrote:
>> Nice catch. What made you decide to do this rather than change AddLLVM.cmake?
> 
> AFAICT this approach uses the AddLLVM APIs as designed.  They already
> know not to install targets when EXCLUDE_FROM_ALL is enabled but were
> not told about the setting in this case within Clang.

Seems fair—there's not a great way to pass that down to add_target otherwise. 
Committed as r201799.

Thanks!
Jordan


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to